javadoc: remove a comment documented a limitation on @Lookup annotation #25044
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lookup method Spring can dynamically override an abstract @Lookup-annotated method to create a concrete class backing a bean, and this works with beans defined by @component annotation.
|
@urisimchoni Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@urisimchoni Thank you for signing the Contributor License Agreement! |
|
Confirmed. |
jhoeller
added
in: core
|
I've revised the section a bit differently, turning it into recommendations and still referring to potential use of stub methods - but not in the context of component scanning anymore, good catch there! And thanks for the pull request, in any case... |
FelixFly
pushed a commit
to FelixFly/spring-framework
that referenced
this pull request
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation on @lookup annotation reads:
However it looks like it's possible to define an abstract class, annotated with @component, with an abstract @Lookup-annotated method, and have Spring replace it with a concrete implementation. So this limitation doesn't seem to hold any longer.