-
Notifications
You must be signed in to change notification settings - Fork 38.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing @PathVariable declarations in examples in webmvc.adoc #25006
Conversation
We say " For example, given URL "/spring-web-3.0.5 .jar", the following method extracts the name, version, and file extension:" So added PathVariable name to complete the code.
minor fix for kotlin
@swapy Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@swapy Thank you for signing the Contributor License Agreement! |
Thanks for the PR. We'll get this merged soon. |
@@ -1634,15 +1634,15 @@ extracts the name, version, and file extension: | |||
.Java | |||
---- | |||
@GetMapping("/{name:[a-z-]+}-{version:\\d\\.\\d\\.\\d}{ext:\\.[a-z]+}") | |||
public void handle(@PathVariable String version, @PathVariable String ext) { | |||
public void handle(@PathVariable name, @PathVariable String version, @PathVariable String ext) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: you accidentally deleted the String
type declaration for the name
parameter.
But don't worry about it: I've fixed it locally prior to merging.
public void handle(@PathVariable name, @PathVariable String version, @PathVariable String ext) { | |
public void handle(@PathVariable String name, @PathVariable String version, @PathVariable String ext) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for that and thanks a lot. I will be careful next time.
We say
For example, given URL "/spring-web-3.0.5 .jar", the following method extracts the name, version, and file extension:
So added PathVariable name to complete the code.