Rid pointless wrapping with BufferedInputStream from class reading #24946
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of
SimpleMetadataReader.getClassReader()
wrapsInputStream
of argument resource withBufferedInputStream
which is pointless. Rationale:ClassReader.readStream()
BufferedInputStream
and inClassReader.readStream()
: 8192 vs 4096 which means thatClassReader.readStream()
has to do two calls to read full buffer ofBufferedInputStream
InputStreams
returned from JDK classes are already wrapped intoBufferedInputStream
, e.g.FileURLConnection.getInputStream()
or built aroundByteBuffer
I've used the benchmark to measure impact of this change:
For JDK 8 and 11 it gives
While execution time is only slightly better, memory consumption is 16-24% lower.