-
Notifications
You must be signed in to change notification settings - Fork 38.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve usage of ByteArrayOutputStream/ByteArrayInputStream #24805
Closed
+47
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrannen
reviewed
Mar 30, 2020
sbrannen
reviewed
Mar 30, 2020
sbrannen
reviewed
Mar 30, 2020
For future reference, please make sure you execute
|
@sbrannen let me push once again )) |
I've already begun a local merge process. So no need to push again. |
Ok, I was unaware about |
sbrannen
added a commit
that referenced
this pull request
Mar 30, 2020
izeye
added a commit
to izeye/samples-jmh-gradle
that referenced
this pull request
Apr 10, 2020
jhoeller
added a commit
that referenced
this pull request
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByteArrayInputStream.flush()
is no-op method along withByteArrayInputStream.close()
,ByteArrayOutputStream.flush()
andByteArrayOutputStream.close()
. So we can droptry-with-resources
statements as well as explicit calls toflush()
/close()
new String(BAOS.toByteArray(), charset)
replaced with call toStreamUtils.baosToString(baos, charset)
to swallowUnsupportedEncodingException
which is actually never thrown ascharset
is already available at invocation pointAs of performance I've used more precise benchmark:
Which demonstrates improvement in both time and memory consumption