Simplify conversion of ByteArrayOutputStream to String #24785
Closed
+6
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we often convert BAOS to String as
which can be made more simple and effective as
BAOS.toByteArray()
creates a copy of underlying array which is later decoded inside ofString
constructor, whileBAOS.toString()
doesn't create intermediate copy making convertion more memory-effective.For JDK 8 I've got following results: