Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractRequestLoggingFilter.isIncludeHeaders() declared as protected #23814

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

endtak
Copy link

@endtak endtak commented Oct 16, 2019

Fix SPR-16881 in 4.3.x. (It was supposed to be backported in 4.3.18, but it was not actually fixed.)

@pivotal-issuemaster
Copy link

@endtak Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 16, 2019
@pivotal-issuemaster
Copy link

@endtak Thank you for signing the Contributor License Agreement!

@rstoyanchev
Copy link
Contributor

@jhoeller did you actually mean to backport this to 4.3.18? I'm not sure that it matters much at this pont but it looks it only made it to 5.0.x.

@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 8, 2019
@rstoyanchev rstoyanchev added this to the 4.3.26 milestone Nov 8, 2019
@rstoyanchev
Copy link
Contributor

Tentatively assigned.

@jhoeller jhoeller changed the title isIncludeHeaders() declared as protected. AbstractRequestLoggingFilter.isIncludeHeaders() declared as protected Nov 13, 2019
@jhoeller jhoeller merged commit b3fb79e into spring-projects:4.3.x Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants