Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When web server application context refresh fails, the original failure is lost if stopping or destroying the web server throws an exception #44310

Closed
wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Feb 17, 2025

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 17, 2025
@wilkinsona wilkinsona changed the title Suppress WebServer Stop and Destroy Exception if ApplicationContext refresh fails When web server application context refresh fails, the original failure is lost if stopping or destroying the web server throws an exception Feb 17, 2025
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 17, 2025
@wilkinsona wilkinsona added this to the 3.3.x milestone Feb 17, 2025
@nosan nosan changed the base branch from main to 3.3.x February 17, 2025 17:46

Verified

This commit was signed with the committer’s verified signature.
axw Andrew Wilkins
This commit adds the stop or destroy failure as a suppressed
exception if either ServletWebServerApplicationContext or
ReactiveWebServerApplicationContext refresh fails.

Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
@snicoll snicoll self-assigned this Feb 18, 2025
@snicoll snicoll modified the milestones: 3.3.x, 3.3.9 Feb 18, 2025
snicoll pushed a commit that referenced this pull request Feb 18, 2025

Verified

This commit was signed with the committer’s verified signature.
axw Andrew Wilkins
This commit adds the stop or destroy failure as a suppressed
exception if either ServletWebServerApplicationContext or
ReactiveWebServerApplicationContext refresh fails.

See gh-44310

Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
snicoll added a commit that referenced this pull request Feb 18, 2025

Verified

This commit was signed with the committer’s verified signature.
axw Andrew Wilkins
See gh-44310
@snicoll snicoll closed this in 84998f9 Feb 18, 2025
@snicoll
Copy link
Member

snicoll commented Feb 18, 2025

Thanks again, @nosan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants