Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that configuration properties only apply to the auto-configured OpenTelemetry Resource bean #39509

Closed
wants to merge 1 commit into from
Closed

Clarify that configuration properties only apply to the auto-configured OpenTelemetry Resource bean #39509

wants to merge 1 commit into from

Conversation

wanger26
Copy link
Contributor

Change Summary

  • Adjust documentation to describe that exposing a Resource bean, will prevent management.opentelemetry.resource-attributes property from being able to provide attributes

Issue

@wanger26
DOCS - Clarify that auto-configured OpenTelemetry behaviour
0bea903 
The documentation does not describe that exposing a Resource bean, will prevent the property from being able to provide attributes (unless the newly exposed Resource bean, implements it).

Signed-off-by: Jakob Wanger <jakobwanger@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 10, 2024
@mhalbritter mhalbritter mentioned this pull request Feb 12, 2024
Closed
@mhalbritter mhalbritter added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 12, 2024
@mhalbritter mhalbritter added this to the 3.2.x milestone Feb 12, 2024
@mhalbritter mhalbritter self-assigned this Feb 12, 2024
@mhalbritter mhalbritter changed the title DOCS - Clarify that auto-configured OpenTelemetry behaviour Clarify that auto-configured OpenTelemetry Resource bean behaviour Feb 12, 2024
@mhalbritter mhalbritter changed the title Clarify that auto-configured OpenTelemetry Resource bean behaviour Clarify that configuration properties only apply to the auto-configured OpenTelemetry Resource bean Feb 12, 2024
@mhalbritter mhalbritter mentioned this pull request Feb 12, 2024
Closed
mhalbritter pushed a commit that referenced this pull request Feb 12, 2024
@wanger26 @mhalbritter
Clarify that auto-configured OpenTelemetry Resource behaviour
02765bc 
The documentation does not describe that exposing a Resource bean,
will prevent the property from being able to provide attributes
(unless the newly exposed Resource bean, implements it).

Signed-off-by: Jakob Wanger <jakobwanger@gmail.com>

See gh-39509
mhalbritter added a commit that referenced this pull request Feb 12, 2024
@mhalbritter
Polish "Clarify that auto-configured OpenTelemetry Resource behaviour"
6163308 
See gh-39509
@mhalbritter
Copy link
Contributor

Thanks!

@mhalbritter mhalbritter modified the milestones: 3.2.x, 3.2.3 Feb 12, 2024
@Netyyyy Netyyyy mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: documentation A documentation update
Projects
None yet
Milestone
3.2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wanger26 @mhalbritter @spring-projects-issues