Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RestTemplateBuilder#defaultHeader javadoc to reference correct client-side HTTP request class #36614

Closed
wants to merge 1 commit into from

Conversation

rob-valor
Copy link
Contributor

The Javadoc of org.springframework.boot.web.client.RestTemplateBuilder#defaultHeader incorrectly references reactor.netty.http.client.HttpClientRequest. This is now replaced with the correct org.springframework.http.client.ClientHttpRequest.

Replace (incorrect) reactor.netty.http.client.HttpClientRequest with (correct) org.springframework.http.client.ClientHttpRequest
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 27, 2023
@rob-valor rob-valor changed the title Update RestTemplateBuilder javadoc Update RestTemplateBuilder javadoc: remove incorrect refernce to reactor.netty Jul 28, 2023
@rob-valor rob-valor changed the title Update RestTemplateBuilder javadoc: remove incorrect refernce to reactor.netty Update RestTemplateBuilder javadoc: remove incorrect reference to reactor.netty Jul 28, 2023
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 28, 2023
@wilkinsona wilkinsona added this to the 2.7.x milestone Jul 28, 2023
@wilkinsona wilkinsona self-assigned this Jul 28, 2023
@wilkinsona wilkinsona changed the title Update RestTemplateBuilder javadoc: remove incorrect reference to reactor.netty Update RestTemplateBuilder#defaultHeader javadoc to reference correct client-side HTTP request class Jul 28, 2023
@wilkinsona wilkinsona modified the milestones: 2.7.x, 2.7.15 Jul 28, 2023
wilkinsona pushed a commit that referenced this pull request Jul 28, 2023
Replace reactor.netty.http.client.HttpClientRequest with
org.springframework.http.client.ClientHttpRequest

See gh-36614
@wilkinsona
Copy link
Member

@rob-valor Thanks very much for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants