Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency management for Selenium 4.8.x is incorrect #36077

Closed
wants to merge 1 commit into from

Conversation

eddumelendez
Copy link
Contributor

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 26, 2023
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 26, 2023
@philwebb philwebb added this to the 3.2.x milestone Jun 26, 2023

Verified

This commit was signed with the committer’s verified signature.
W-A-James Warren James
@wilkinsona
Copy link
Member

We'll have to double-check the bom's contents but we might be able to apply this to 3.1.x where we're using 4.8.3 which has a bom.

@wilkinsona wilkinsona modified the milestones: 3.2.x, 3.1.x Jun 27, 2023
@wilkinsona wilkinsona changed the title Use Selenium's BOM Use Selenium's bom Jun 27, 2023
@wilkinsona
Copy link
Member

Checking the dependency management in 3.1.x has revealed that what we have at the moment is incorrect. We're managing selenium-devtools-v108 which, in the 4.8.x line, only exists in 4.8.0 and 4.8.1. We aren't managing selenium-devtools-v111 which was introduced in 4.8.2. Switching to the bom will correct this.

@wilkinsona wilkinsona changed the title Use Selenium's bom Dependency management for Selenium 4.8.x is incorrect Jun 27, 2023
@wilkinsona wilkinsona added type: bug A general bug and removed type: task A general task labels Jun 27, 2023
@wilkinsona wilkinsona modified the milestones: 3.1.x, 3.1.2 Jun 27, 2023
wilkinsona pushed a commit that referenced this pull request Jun 27, 2023

Verified

This commit was signed with the committer’s verified signature.
W-A-James Warren James
See gh-36077
@wilkinsona
Copy link
Member

Thanks very much, @eddumelendez.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants