Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods in KafkaConnectionDetails are named inconsistently #35733

Closed
wants to merge 1 commit into from
Closed

Methods in KafkaConnectionDetails are named inconsistently #35733

wants to merge 1 commit into from
+12 −12

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Jun 5, 2023

This PR polishes the changes made in gh-34770 a bit by completing renaming nodes to servers.

It contains a breaking change, but I didn't do anything for it as I don't know what the preference for it is here.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 5, 2023
@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Jun 5, 2023
@philwebb
Copy link
Member

philwebb commented Jun 5, 2023

Thanks @izeye! I wonder what we should do about that method rename since 3.1 is already out. We could deprecate the old one or we could risk it since 3.1 hasn't been out that long and we're probably the only implementers right now.

@philwebb philwebb changed the title Polish gh-34770 Polish KafkaConnectionDetails Jun 5, 2023
@wilkinsona
Copy link
Member

@izeye If it's not too much trouble, would you mind rebasing this PR on top of the latest main? I'm trying to figure out why the PR build ran for 6 hours(!) and hoping that rebasing on top of 3922f1b will help with that.

@izeye izeye force-pushed the polish-gh-34770 branch from 595d7b7 to 60ffe79 Compare June 6, 2023 23:32
@izeye
Copy link
Contributor Author

izeye commented Jun 6, 2023

@wilkinsona Sure, done!

@wilkinsona
Copy link
Member

Thanks very much, @izeye. The PR build was cancelled but we got a thread dump this time which revealed #35771. If you can be bothered, another rebase would be much appreciated.

@izeye izeye force-pushed the polish-gh-34770 branch from 60ffe79 to 62ac0fc Compare June 7, 2023 11:19
@izeye
Copy link
Contributor Author

izeye commented Jun 7, 2023

@wilkinsona Great, done again.

@wilkinsona
Copy link
Member

We discussed this and decided that we'd risk the breaking API change. It's a shame we didn't get this into 3.1.1 but I don't think that should change the decision.

@wilkinsona wilkinsona removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Jun 23, 2023
@wilkinsona wilkinsona changed the title Polish KafkaConnectionDetails Methods in KafkaConnectionDetails are named inconsistently Jun 23, 2023
@wilkinsona wilkinsona added the type: bug A general bug label Jun 23, 2023
@wilkinsona wilkinsona added this to the 3.1.x milestone Jun 23, 2023
@wilkinsona wilkinsona self-assigned this Jun 30, 2023
@wilkinsona wilkinsona mentioned this pull request Jun 30, 2023
Closed
@wilkinsona wilkinsona modified the milestones: 3.1.x, 3.1.2 Jun 30, 2023
wilkinsona pushed a commit that referenced this pull request Jun 30, 2023
@izeye @wilkinsona
Name methods consistently in KafkaConnectionDetails
58a9961 
See gh-35733
@wilkinsona
Copy link
Member

Thanks very much, @izeye.

@izeye izeye deleted the polish-gh-34770 branch June 30, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona

Assignees

@wilkinsona wilkinsona

Labels
type: bug A general bug
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@izeye @philwebb @wilkinsona @spring-projects-issues