Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify servlet container compatibility #34697

Closed

Conversation

jgslima
Copy link

@jgslima jgslima commented Mar 21, 2023

Fix documentation section on web container requirements for 2.7.x.

This is relevant for teams and companies that are planning upgrade to Spring Boot 3, upgrade the web container used, and so on.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 21, 2023
@jgslima
Copy link
Author

jgslima commented Mar 21, 2023

As a side note, this highlights an import aspect of environments that use a web container like Tomcat, to run .war applications (which is the case for many customers of the company I work for).

When upgrading to Spring Boot 3, Tomcat 10.1 must be upgraded (and not before) and also, all .war applications deployed in the same web container must be upgraded to Servlet API 5.0+.

All due to the jakarta namespace change.

@wilkinsona wilkinsona added type: documentation A documentation update for: merge-with-amendments Needs some changes when we merge and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 23, 2023
@wilkinsona wilkinsona added this to the 2.7.x milestone Mar 23, 2023
@wilkinsona
Copy link
Member

I think we could simplify this a bit, by replacing the + with or 4.0:

You can also deploy Spring Boot applications to any Servlet 3.1 or 4.0 compatible container

If we want to go into any more detail, we could then explain that Servet 5.0 broke backwards compatibility but I'm not sure it's necessary.

@wilkinsona wilkinsona changed the title Fix web container requirements. Clarify servlet container compatibility Mar 23, 2023
@wilkinsona wilkinsona removed the for: merge-with-amendments Needs some changes when we merge label Mar 25, 2023
@snicoll snicoll self-assigned this Apr 7, 2023
@snicoll snicoll modified the milestones: 2.7.x, 2.7.11 Apr 11, 2023
snicoll pushed a commit that referenced this pull request Apr 11, 2023
@snicoll snicoll closed this in 5a6e7d1 Apr 11, 2023
@snicoll
Copy link
Member

snicoll commented Apr 11, 2023

@jgslima thank you for making your first Spring Boot contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants