-
Notifications
You must be signed in to change notification settings - Fork 41.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for descriptions of record components in configuration metadata generation #29403
Conversation
…ponent_descriptions
…ponent_descriptions
…ponent_descriptions
Thanks for the PR, @An1s9n. While looking at this I noticed some existing problems with detecting deprecated record components and opened #29526. We somewhat accidentally fell into using I think we need to take a bit of a step back and review how we're handling records in general. My suspicion at the moment is that we'll either want separate property description classes for records and classes or we'll want to use composition a bit more so that we can plug in strategies for identifying property accessors and extract property descriptions from javadoc. I'm going to put this one on hold until we've had a chance to do that. |
Hi! Has there been any updates and/or design work on this? |
No, not yet I'm afraid. Updates will appear here or in a linked issue when we have them. |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
Update `spring-boot-configuration-processor` to support generating configuration metadata from record parameter javadoc. See gh-29403
Restructure `PropertyDescriptor` type hierarchy and polish code. See gh-29403
Thanks very much for the PR @An1s9n, and for your patience whilst we got around to merging it. I've just merged this into main so that it will be available as part of the 3.3 release. Ordinarily we wouldn't make changes like this post RC, but I think it's worth making an exception for this one since it's relatively isolated and a lot of folks have voted on the issue. For anyone watching this issue, please give the SNAPSHOT a try (when https://github.com/spring-projects/spring-boot/actions/runs/8788352195 has finished) and let us know if there are problems. We have a few weeks to iron out any issues. |
Hello everyone!
While working on PR #29010 I've noticed that now there is no way to automatically generate descriptions in configuration metadata if you use
@ConfigurationProperties
with record class. Indeed, there are no explicit fields to put regular field-level Javadocs on. But there is an official way for records to do so: descriptions should be provided via class-level Javadoc tag@param
.I've added support for such usage, added test and mentioned it in reference documentation. I assume test is clear enough for understanding what I've done. Hope build will pass :)