Broaden Checkstyle rule for AssertJ assertion enforcement #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to spring-projects/spring-framework#31116 |
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Oct 13, 2023
wilkinsona
added a commit
that referenced
this pull request
Oct 13, 2023
|
Thanks very much, @izeye. I assumed that the intention here was to broaden the enforcement for projects using Spring Java Format. The change as you had made it affected Spring Java Format itself and not the Checkstyle rules that it applies to other projects. I've corrected that in 2909060. Note that I undid your original change as part of this as it caused a build failure due to the blunt regex-based approach matching some code that wasn't actually an import. Please let me know if I've got this wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Checkstyle rule for AssertJ assertion enforcement to include JUnit Jupiter and broaden the scope of
org.junit.Assertby removing the ".assert" part.