Support build scan link for CircleCI #31
Conversation
| private boolean isCircleCi() { | ||
| return this.env.containsKey("CIRCLECI"); | ||
| } | ||
|
|
||
| private boolean isConcourse() { | ||
| return this.env.containsKey("CI"); |
There was a problem hiding this comment.
CircleCI also sets an env var CI=true on its builds. I'm not sure if there is a more discerning env var for Concourse. Right now it is not practically an issue since CircleCI is checked before Concourse, but it does feel fragile to potential future changes in this code.
There was a problem hiding this comment.
Concourse doesn't expose any environment variables by default. CI is something that we unimaginatively came up with ourselves and configure in our pipeline. We should change it to something more specific.
There was a problem hiding this comment.
For other CI systems that we support in the Common Custom User Data Gradle plugin, we detect the presence of the URL environment variable like so: https://github.com/gradle/gradle-enterprise-build-config-samples/blob/master/common-custom-user-data-gradle-plugin/src/main/java/com/gradle/CustomBuildScanEnhancements.java#L175
Detects running on CircleCI and configures the build scan with a link to the CI build job URL.
Detects running on CircleCI and configures the build scan with a link to the CI build job URL. See gh-31
Detects running on CircleCI and configures the build scan with a link to the CI build job URL.