Skip to content

Commit

Permalink
Consider toolchainVersion project property when tagging JDK version
Browse files Browse the repository at this point in the history
Closes gh-22
  • Loading branch information
wilkinsona committed Apr 14, 2021
1 parent e503656 commit 2dd3b57
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ private boolean isJenkins() {
}

private void tagJdk(ConfigurableBuildScan buildScan) {
buildScan.tag("JDK-" + System.getProperty("java.specification.version"));
buildScan.tag("JDK-" + getJdkVersion());
}

protected String getJdkVersion() {
return System.getProperty("java.specification.version");
}

private void tagOperatingSystem(ConfigurableBuildScan buildScan) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,26 @@ private void configureBuildScanConventions(BuildScanExtension buildScan, StartPa
new WorkingDirectoryProcessOperations(this.processOperations, rootDir));
GradleConfigurableBuildScan configurableBuildScan = new GradleConfigurableBuildScan(buildScan);
if (startParameter.isBuildScan()) {
new AnonymousPublicationBuildScanConventions(processRunner).execute(configurableBuildScan);
new AnonymousPublicationBuildScanConventions(processRunner) {

@Override
protected String getJdkVersion() {
String toolchainVersion = startParameter.getProjectProperties().get("toolchainVersion");
return (toolchainVersion != null) ? toolchainVersion : super.getJdkVersion();
}

}.execute(configurableBuildScan);
}
else {
new BuildScanConventions(processRunner).execute(configurableBuildScan);
new BuildScanConventions(processRunner) {

@Override
protected String getJdkVersion() {
String toolchainVersion = startParameter.getProjectProperties().get("toolchainVersion");
return (toolchainVersion != null) ? toolchainVersion : super.getJdkVersion();
}

}.execute(configurableBuildScan);
}
}
}
Expand Down

0 comments on commit 2dd3b57

Please sign in to comment.