improves traceQueue cleaning logic #2241
Merged
+420
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit improves logic on when the previous TraceContext has to be cleaned by looking at the last reader thread as well as last polled value and tries to match it with the context that was available before. If context was available when the previous reader is different from the current or when the previous value is null, the logic assumes that the thread offered value and then draining queue is the same, so there is no need to clear context after the last value is drained and that responsibility is on the reader Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
marcingrzejszczak
approved these changes
Jan 3, 2023
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit improves logic on when the previous TraceContext has to be cleaned by looking at the last reader thread as well as the last polled value and trying to match it with the context that was available before. If the context was available when the previous reader is different from the current or when the previous value is null, the logic assumes that the thread offered value and then draining queue is the same, so there is no need to clear context after the last value is drained and that responsibility is on the reader.
Signed-off-by: Oleh Dokuka oleh.dokuka@icloud.com