Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit about using Protobuf 3 in Scio #5618

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

clairemcginty
Copy link
Contributor

Currently different BOMs pull in mixed Protobuf 3 and 4 deps, and 3 wins the dependency conflict. Let's be explicit about which major version we're using in Scio until Beam/GCP BOMs agree on a major version.

See: #5617

@clairemcginty clairemcginty requested a review from kellen February 26, 2025 17:58
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.33%. Comparing base (d306bdb) to head (b88889b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5618   +/-   ##
=======================================
  Coverage   61.33%   61.33%           
=======================================
  Files         314      314           
  Lines       11257    11257           
  Branches      782      782           
=======================================
+ Hits         6904     6905    +1     
+ Misses       4353     4352    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clairemcginty clairemcginty merged commit 93a20de into main Feb 26, 2025
12 checks passed
@clairemcginty clairemcginty deleted the proto-3-explicit branch February 26, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants