Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix REPL assembly #5614

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Fix REPL assembly #5614

merged 1 commit into from
Feb 25, 2025

Conversation

clairemcginty
Copy link
Contributor

after upgrading Beam to 2.63.0, (#2390), scio-repl was failing with:

[error] 1 error(s) were encountered during the merge:
[error] java.lang.RuntimeException: 
[error] Deduplicate found different file contents in the following:
[error]   Jar name = beam-vendor-grpc-1_69_0-0.1.jar, jar org = org.apache.beam, entry target = mozilla/public-suffix-list.txt
[error]   Jar name = httpclient-4.5.13.jar, jar org = org.apache.httpcomponents, entry target = mozilla/public-suffix-list.txt

@clairemcginty clairemcginty requested a review from kellen February 25, 2025 13:42
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.33%. Comparing base (166a22a) to head (5e94d7f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5614   +/-   ##
=======================================
  Coverage   61.33%   61.33%           
=======================================
  Files         314      314           
  Lines       11255    11255           
  Branches      802      802           
=======================================
  Hits         6903     6903           
  Misses       4352     4352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clairemcginty clairemcginty merged commit 03ff143 into main Feb 25, 2025
12 checks passed
@clairemcginty clairemcginty deleted the fix-repl-assembly branch February 25, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant