Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close client in async DoFn #5206

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Close client in async DoFn #5206

merged 1 commit into from
Jan 26, 2024

Conversation

RustedBones
Copy link
Contributor

No description provided.

@RustedBones RustedBones force-pushed the async-dofn-close-client branch from 7ed57c5 to f0b0d13 Compare January 25, 2024 15:44
@RustedBones RustedBones force-pushed the async-dofn-close-client branch from f0b0d13 to 54ab565 Compare January 25, 2024 15:54
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (964aad7) 63.06% compared to head (54ab565) 62.56%.
Report is 4 commits behind head on main.

Files Patch % Lines
...om/spotify/scio/coders/instances/ScalaCoders.scala 78.94% 4 Missing ⚠️
...spotify/scio/coders/instances/AlgebirdCoders.scala 60.00% 2 Missing ⚠️
...tify/scio/coders/extra/sparkey/SparkeyCoders.scala 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5206      +/-   ##
==========================================
- Coverage   63.06%   62.56%   -0.51%     
==========================================
  Files         300      301       +1     
  Lines       10947    10807     -140     
  Branches      740      764      +24     
==========================================
- Hits         6904     6761     -143     
- Misses       4043     4046       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RustedBones RustedBones merged commit 9922568 into main Jan 26, 2024
11 checks passed
@RustedBones RustedBones deleted the async-dofn-close-client branch January 26, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants