Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-deprecated version of murmur3_32 #5204

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Use non-deprecated version of murmur3_32 #5204

merged 1 commit into from
Jan 26, 2024

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Jan 25, 2024

This doesn't have any impact on users relying on this since we don't leverage the affect hashing method.

google/guava@a36f08f

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This doesn't have any impact if users are relying on this since we don't leverage the affect hashing method.

google/guava@a36f08f
@regadas regadas requested a review from clairemcginty January 25, 2024 14:57
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (964aad7) 63.06% compared to head (7a6d110) 62.57%.
Report is 4 commits behind head on main.

Files Patch % Lines
...om/spotify/scio/coders/instances/ScalaCoders.scala 78.94% 4 Missing ⚠️
...spotify/scio/coders/instances/AlgebirdCoders.scala 60.00% 2 Missing ⚠️
...tify/scio/coders/extra/sparkey/SparkeyCoders.scala 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5204      +/-   ##
==========================================
- Coverage   63.06%   62.57%   -0.50%     
==========================================
  Files         300      301       +1     
  Lines       10947    10807     -140     
  Branches      740      764      +24     
==========================================
- Hits         6904     6762     -142     
- Misses       4043     4045       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clairemcginty clairemcginty merged commit a6303ac into main Jan 26, 2024
11 checks passed
@clairemcginty clairemcginty deleted the smb_hash branch January 26, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants