-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race in sparkey write #4937
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.14.x #4937 +/- ##
===========================================
+ Coverage 62.98% 63.36% +0.37%
===========================================
Files 282 284 +2
Lines 10648 10698 +50
Branches 789 781 -8
===========================================
+ Hits 6707 6779 +72
+ Misses 3941 3919 -22
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this target 0.14 as this is breaking mima ?
Intended to fix #4890
Introduces a write to a temporary location before a finalization step moving temp files to their final destination.
Unifies the various SparkeyUri subclasses for simpler handling, removes kryo coder, moves provision of RemoteFileUtil to transform steps.