Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WorkflowsResponse.deletedAt field nullable #203

Merged

Conversation

mitulamin
Copy link
Contributor

deletedAt field in WorkflowsResponse is not required according to the schema and therefore should be marked @nullable.

Running without this fix causes an exception when deserialising the json response from GitHub with the root cause:

Cannot build WorkflowsResponse, some of required attributes are not set [deletedAt]

@dennisgranath dennisgranath merged commit a239d3c into spotify:master Jan 17, 2025
3 checks passed
@mitulamin
Copy link
Contributor Author

Thank you

@mitulamin mitulamin deleted the fix/nullable-workflow-deletedAt branch January 23, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants