Do not report URF_UNREAD_FIELD for fields with certain annotations
#2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Implements test case for @SerializedName -Adjusts UnreadFields file to skip fields with @SerializedName annotation -Confirms URF_UNREAD_FIELD bugs in Issue574Test.java
-Refactors code initially placed in "UnreadFields.java" to new util class ("UnreadFieldsAnnotationChecker.java")
-Adds support for checking for XmlAttribute and XmlValue tags
-Separates test classes for different annotation groups
…xtension -Added support for suppressing warnings related to @RegisterExtension annotation
JuditKnoll
requested changes
Feb 23, 2024
spotbugs/src/main/java/edu/umd/cs/findbugs/util/UnreadFieldsAnnotationChecker.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/util/UnreadFieldsAnnotationChecker.java
Outdated
Show resolved
Hide resolved
spotbugs/src/main/java/edu/umd/cs/findbugs/util/UnreadFieldsAnnotationChecker.java
Outdated
Show resolved
Hide resolved
spotbugsTestCases/src/java/ghIssues/issue574/Issue574RegisterExtension.java
Show resolved
Hide resolved
ThrawnCA
approved these changes
Feb 25, 2024
JuditKnoll
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there was no answer in #1861 I've merged the proposed changes and made my own changes on top:
I think the comment to move
UnreadFieldsAnnotationCheckerintoUnreadFieldshas merits (since the class is only used there) but I haven't made the change to preserve the Git history. Let me know if you think the change should be made.This should fix #574 and supersede #1861