Remove AppleExtension library #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thank you for tackling this one. |
hazendaz
approved these changes
Jan 20, 2024
|
@Spatrik95 I'll go ahead and merge and add change log afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official Apple documentation describes that the OSXAdapter class makes work of the macOS Application Bar's Quit, About, and Preferences menu items. I removed the extension library and the adapter class from the codebase, and I tried the GUI again, and the menu items are still working. The About and Quit items are working as they should. The Preferences menu doesn't exist, but the Preferences/Reconfigure menu item can be found under the File menu. It's okay, I guess.
I tested with the
./spotbugsand./spotbugs2commands too and the application is working fine, I can load files, use the functions.I compiled by Java 21.0.1 (12) and tested on macOS Sonoma 14.2.1. I didn't get any exceptions on the console while I tested the application.
Some screenshot:
fixes #1324
fixes #418
fixes #2818