Fix FPs in CT_CONSTRUCTOR_THROW when the finalizer does not run

[JuditKnoll]

This PR fixes #2710.

---

Make sure these boxes are checked before submitting your PR -- thank you!

• Added an entry into CHANGELOG.md if you have changed SpotBugs code

[hazendaz]

We should automate the changelog entry somehow from an action, its always conflicting

[iloveeclipse]

Because of the merge in between Merge branch 'master' into ct_fix_2710 this PR can't be rebased.

I've fixed that & properly rebased the change plus fixed inconsistencies in the current changelog.
Will push on the branch in a moment.

[JuditKnoll]

Because of the merge in between Merge branch 'master' into ct_fix_2710 this PR can't be rebased.

I've fixed that & properly rebased the change plus fixed inconsistencies in the current changelog. Will push on the branch in a moment.

@iloveeclipse Isn't a merging the master to the feature branch generally preferred, than rebasing to master? Since the latter changes the commit ids, makes the review a bit more difficult (the changes since the last review can't be reviewed easily), and requires a force push, also it's easier for less experienced git users to delete changes and make a mess. I would love to hear your point on this.

[iloveeclipse]

I always prefer rebase and avoid using merge if possible, also for non trivial PR's I always use IDE and not web UI.
There are few items that make "merge" not nice:

• "Rebased" work is much easier to follow / test single changes.
• Rebasing merge commits is not possible at all.
• Reviewing merge commits is a mess, as that hides the actual changes behind potentially huge number of changes.
• One can always "re-apply" non-merge commits to any branch to see what the change would do there - not possible with merge commits
• May be more here.

So from my point of view (I spend 90% of my work time on reviews) merge is a biggest possible PITA.

[hazendaz]

Agreed! I rebase extensively. Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Andrey Loskutov ***@***.***> Sent: Tuesday, November 28, 2023 5:44:52 AM To: spotbugs/spotbugs ***@***.***> Cc: Jeremy Landis ***@***.***>; Comment ***@***.***> Subject: Re: [spotbugs/spotbugs] Fix FPs in CT_CONSTRUCTOR_THROW when the finalizer does not run (PR #2716) I always prefer rebase and avoid using merge if possible, also for non trivial PR's I always use IDE and not web UI. There are few items that make "merge" not nice: * "Rebased" work is much easier to follow / test single changes. * Rebasing merge commits is not possible at all. * Reviewing merge commits is a mess, as that hides the actual changes behind potentially huge number of changes. * One can always "re-apply" non-merge commits to any branch to see what the change would do there - not possible with merge commits * May be more here. So from my point of view (I spent 90% of my work time on reviews) merge is a biggest possible PITA. — Reply to this email directly, view it on GitHub<#2716 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI7LO4NUMTKOL4LSCQLYGW6CJAVCNFSM6AAAAAA74JQFZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZGU3DAMBZGI>. You are receiving this because you commented.Message ID: ***@***.***>