Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindOverridableMethodCall is not thread safe #2702

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

iloveeclipse
Copy link
Member

Don't use static maps for analysis specific data, it can't work with multiple analysis running in same JVM, like it might happen in Eclipse.

Fixes #2701

Don't use static maps for analysis specific data, it can't work with
multiple analysis running in same JVM, like it might happen in Eclipse.

Fixes spotbugs#2701
Copy link
Contributor

@gtoison gtoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, too bad there wasn't a detector to find that issue :)

@iloveeclipse iloveeclipse merged commit a9ed9ef into spotbugs:master Nov 15, 2023
6 checks passed
@iloveeclipse iloveeclipse deleted the issue_2701 branch November 15, 2023 13:36
@hazendaz hazendaz added this to the SpotBugs 4.8.2 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FindOverridableMethodCall detector is not thread safe
3 participants