Use java.nio to load filter files #2684
Conversation
java.io.FileInputStream seems to be running into issues when trying to load files with non-ascii charatecter in the file name. Other similar issues point to this happening on a Mac, so it might be dependent on the combination of OS/JDK version/user settings Originally reported here: JetBrains/spotbugs-intellij-plugin#1492
gtoison
changed the title
There was a problem hiding this comment.
Tried to reproduce the problem with the provided test without the solution both on a Windows and on a Linux machine (using OpenJDK 17 on both), but I couldn't, the test was successful before using java.nio, and after as well.
If using java.nio solves the problem, it may be worth to look at and consider using java.nio in other places operating with Files as well to prevent similar issues.
| @@ -9,6 +9,7 @@ Currently the versioning policy of this project follows [Semantic Versioning v2. | |||
|
|
|||
| ### Fixed | |||
| - Fixed false positive UPM_UNCALLED_PRIVATE_METHOD for method used in JUnit's MethodSource ([[#2379](https://github.com/spotbugs/spotbugs/issues/2379)]) | |||
| - Use java.nio to load filter files ([[#2684](https://github.com/spotbugs/spotbugs/pull/2684)]) | |||
There was a problem hiding this comment.
Are you sure, you wanted to refer the PR here and not the fixed issue?
There was a problem hiding this comment.
The issue in the IntelliJ plugin, since Jetbrains does not seem to be actively maintaining it I think it will take a while until the plugin gets the updated version
There was a problem hiding this comment.
In this exact instance, I get it. However, I couldn't find the general logic yet, when exactly is referenced the issue, and when the PR, when there are no links? The links seems the same, when looking at the preview of the file (not the raw version), which may be a bit confusing for the reader. Until this point, I only refered the fixed issues. Could you please clarify this to me? (It's a bit off topic here, sorry about it.)
There was a problem hiding this comment.
I don't know either to be honest, but as a user I would expect a link to something giving some context as to what was changed and why
java.io.FileInputStreamseems to be running into issues when trying to load files with non-ascii charatecter in the file name.Other similar issues point to this happening on a Mac, so it might be dependent on the combination of OS/JDK version/user settings.
Although the test did not reproduce the problem I think that using
java.nioshould help.Note that I'm using
FileSystems.getDefault().getPath(...)instead ofPath.of(...)because it is only available since JDK 11.Originally reported here:
JetBrains/spotbugs-intellij-plugin#1492
Other links discussing similar problems:
https://stackoverflow.com/questions/22775758/java-io-file-accessing-files-with-invalid-filename-encodings
https://ogris.de/howtos/java-utf8-filenames.html
https://stackoverflow.com/questions/14171565/java-read-write-unicode-utf-8-filenames-not-contents