[checkstyle] Bump to 10.12.7, add spring dependency management to fix gradle exclusion defects #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: To not hammer system it redoing build, I've fixed the changelog PR in separate effort with some other change log entries that I'll push separately. |
gtoison
reviewed
Jan 6, 2024
|
Once build finishes will merge, per previous discussions then help from checkstyle comments on better way to do this. This way ensures we don't mess up our dependency management and cause users other unexpected side effects. Fixed up change log as well as two build areas in this release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented with spring here spring-gradle-plugins/dependency-management-plugin#211, there is a long standing defect in exclusion handling within gradle. With more recent checkstyle, we cannot apply due to exclusion that is not being adhered to.
See checkstyle/checkstyle#14211 for checkstyle info on situation.
See #2752 for our failures trying to pick up latest with the exclusion.