Skip to content

Commit

Permalink
[checkstyle] Bump to 10.12.7, add spring dependency management to fix…
Browse files Browse the repository at this point in the history
… gradle exclusion defects
  • Loading branch information
hazendaz committed Jan 7, 2024
1 parent 39a6f1e commit 7b55011
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ Currently the versioning policy of this project follows [Semantic Versioning v2.
- Move information contained in the SARIF property `exitSignalName` to `exitCodeDescription` ([#2739](https://github.com/spotbugs/spotbugs/issues/2739))
- Do not report SE_NO_SERIALVERSIONID or other serialization issues for records ([#2793](https://github.com/spotbugs/spotbugs/issues/2793))

### Build
- Add 'io.spring.dependency-managagement' to control bug in gradle on exclusions not being excluded properly as seen in checkstyle usage. See https://github.com/checkstyle/checkstyle/issues/14211 for more information. ([#2798](https://github.com/spotbugs/spotbugs/issues/2798))

## 4.8.3 - 2023-12-12
### Fixed
- Fix FP in CT_CONSTRUCTOR_THROW when the finalizer does not run, since the exception is thrown before java.lang.Object's constructor exits for checked exceptions ([#2710](https://github.com/spotbugs/spotbugs/issues/2710))
Expand Down
1 change: 1 addition & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ plugins {
id "org.gradle.crypto.checksum" version "1.4.0"
id "com.github.spotbugs" version "6.0.5"
id "io.github.gradle-nexus.publish-plugin" version "1.3.0"
id "io.spring.dependency-management" version "1.1.4"
}

group = 'com.github.spotbugs'
Expand Down
9 changes: 8 additions & 1 deletion gradle/checkstyle.gradle
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
// Setup checkstyle
apply plugin: 'checkstyle'
apply plugin: 'io.spring.dependency-management'

dependencyManagement {
dependencies {
dependency 'com.puppycrawl.tools:checkstyle:10.12.7'
}
}

checkstyle {
toolVersion '10.12.5'
toolVersion '10.12.7'
ignoreFailures false
configFile file("$rootDir/spotbugs/etc/checkstyle.xml") // TODO : This config file is lame and should be moved out...
}
Expand Down

0 comments on commit 7b55011

Please sign in to comment.