Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread safety issue with encoding tables #515

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fix thread safety issue with encoding tables #515

merged 2 commits into from
Jul 31, 2023

Commits on Jul 31, 2023

  1. Fix thread safety issue with encoding tables 

    Fix: sporkmonger#514
Fix: oracle/truffleruby#3166

These hashes lazily memoize percent encoded characters, this is an
issue on GVL-less Ruby implementations as it can cause concurrent
access.

But these are actually quite wastful as the key is always a single byte
so rather than use string keys are lazily memoize these, we can precompute
two static arrays of 255 elements once and for all.
    @byroot
    byroot committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    203eafd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into precompute-constants

    @dentarg
    dentarg committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    6ab4966 View commit details
    Browse the repository at this point in the history