Define URI::NONE as a module to avoid serialization issues #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it's an anonymous objects, when serialized and restored by Marshal or YAML, the restored instance has a diferent anonymous object as ivar values. The simplest fix for this is to use a named module.
casperisfine
force-pushed
the
improve-serialization
branch
from
8d9350e
to
30a38d6
Compare
Merged
|
@tenderlove does this look good to you? |
|
@dentarg yep, it looks good to me! |
|
Thanks @tenderlove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it's an anonymous objects, when serialized and restored by Marshal or YAML, the restored instance has a diferent anonymous object as ivar values.
The simplest fix for this is to use a named module.
This is related to #508, but only focus on current version compatibility.
cc @tenderlove