Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure reset of deferred validation #481

Merged
merged 3 commits into from
Dec 15, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/addressable/uri.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2392,7 +2392,8 @@ def defer_validation
yield
@validation_deferred = false
validate
return nil
ensure
@validation_deferred = false
end

protected
Expand Down
22 changes: 22 additions & 0 deletions spec/addressable/uri_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6743,3 +6743,25 @@ def to_str
).to eq(main)
end
end

describe Addressable::URI, "when deferring validation" do
subject(:deferred) { uri.instance_variable_get(:@validation_deferred) }

let(:uri) { Addressable::URI.parse("http://example.com") }

it "defers validation within the block" do
uri.defer_validation do
expect(deferred).to be true
end
end

it "always resets deferal afterward" do
dentarg marked this conversation as resolved.
Show resolved Hide resolved
expect { uri.defer_validation { raise "boom" } }.to raise_error("boom")
expect(deferred).to be false
end

it "returns nil" do
res = uri.defer_validation {}
expect(res).to be nil
end
end