Fix YAML serialization #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd need to examine the values, but maybe we could use a symbol or number instead of a singleton object instance? Then we don't need to implement the yaml coder stuff |
Yes and no. It would work for newly serialized objects, however if you have some serialized |
Ref: sporkmonger#486 Following the introduction of `NONE` flags, `Addressable::URI` instance can no longer be correctly serialized with YAML. It appear to work, but `NONE` is serialized as `!ruby/object {}`, so when the YAML is parsed back, the attributes are assigned a distinct anonymous object.
casperisfine
force-pushed
the
yaml-backward-compat
branch
from
07715c7
to
ed47f3a
Compare
|
Is #509 needed if this is merged? |
|
@tenderlove did you have any other idea or are you okay with this? |
|
@dentarg I don't have any better ideas, I think we should merge this 😅 |
casperisfine
pushed a commit
to Shopify/rails
that referenced
this pull request
Jul 6, 2023
This help treating caches entries as expandable. Because Marshal will hapily serialize almost everything, It's not uncommon to inadvertently cache a class that's not particularly stable, and cause deserialization errors on rollout when the implementation changes. E.g. sporkmonger/addressable#508 With this change, in case of such event, the hit rate will suffer for a bit, but the application won't return 500s responses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #486
Following the introduction of
NONEflags,Addressable::URIinstance can no longer be correctly serialized with YAML.It appear to work, but
NONEis serialized as!ruby/object {}, so when the YAML is parsed back, the attributes are assigned a distinct anonymous object.FYI: @tenderlove