Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(style): add prettier lint pre commit for markdown files #1199

Merged
merged 5 commits into from
May 17, 2024

Conversation

soleksy-splunk
Copy link
Contributor

@soleksy-splunk soleksy-splunk commented May 16, 2024

Summary

Add Markdown pre-commit linter

Changes

Added https://github.com/igorshubovych/markdownlint-cli as pre-commit linter for markdown files

User experience

End user experience does not change.
Changes made by developers are easier to align into single pattern.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@artemrys
Copy link
Member

Unfortunately, this prettier mirror by pre-commit seems to be deprecated and archived.

Maybe something like markdown lint project?

@soleksy-splunk soleksy-splunk force-pushed the chore/add-docs-pre-commit-lint branch from c8183c9 to 28a765b Compare May 17, 2024 01:48
@soleksy-splunk
Copy link
Contributor Author

Unfortunately, this prettier mirror by pre-commit seems to be deprecated and archived.

Maybe something like markdown lint project?

true i missed that one that it is deprecated, changed into that markdownlint , seems like it is one of most commonly used
https://github.com/igorshubovych/markdownlint-cli

@artemrys artemrys changed the title chore: add prettier lint pre commit for markdown files chore(style): add prettier lint pre commit for markdown files May 17, 2024
@artemrys artemrys enabled auto-merge (squash) May 17, 2024 14:50
@artemrys artemrys merged commit e4b6d1e into develop May 17, 2024
61 checks passed
@artemrys artemrys deleted the chore/add-docs-pre-commit-lint branch May 17, 2024 15:22
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants