Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge develop into main #1196

Merged
merged 20 commits into from
May 14, 2024
Merged

chore: merge develop into main #1196

merged 20 commits into from
May 14, 2024

Conversation

sgoral-splunk
Copy link
Contributor

No description provided.

vtsvetkov-splunk and others added 20 commits April 30, 2024 14:54
jinja2 to v3.1.4
[changelog](https://jinja.palletsprojects.com/changes/)) | `3.1.3` ->
`3.1.4` 

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…1175)

- Remove white background from the checkboxgroup storybook
- Update the checkboxgroup screenshot and docs.
- add a default value for the required field in checkboxgroup.

---------

Co-authored-by: srv-rr-github-token <94607705+srv-rr-github-token@users.noreply.github.com>
Co-authored-by: Artem Rys <rysartem@gmail.com>
lockFileMaintenance, All locks refreshed
update eslint to ^8.26.0
---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Szymon Oleksy <soleksy@splunk.com>
Separation done similar to:
https://splunk.github.io/addonfactory-ucc-generator/advanced/custom_rest_handler/

Fixes #331.

Co-authored-by: mahirchavda <mahir.chavda13@gmail.com>

---------

Co-authored-by: Artem Rys <rysartem@gmail.com>
…figuration page (#1181)

- Added support for text truncation when the page width is too small.
- Adjusted the button width to prevent the label from overflowing beyond
the button's border.
- Here is the reference: 
screenshot before the fix:

<img width="1028" alt="Screenshot 2024-05-06 at 11 44 03 AM"
src="https://github.com/splunk/addonfactory-ucc-generator/assets/163995910/821bfb86-e39d-4d36-af0c-80ef0e84d682">

screenshot after the fix:

<img width="1053" alt="Screenshot 2024-05-09 at 3 01 32 PM"
src="https://github.com/splunk/addonfactory-ucc-generator/assets/163995910/471fe0b8-90ba-4148-8c9d-9b89268f7410">

---------

Co-authored-by: srv-rr-github-token <94607705+srv-rr-github-token@users.noreply.github.com>
Co-authored-by: Artem Rys <rysartem@gmail.com>
- Update `@splunk/react-ui` to v4.30.0
This PR introduces a new PR template.
)

This PR adds a new GitHub issue for documentation updates.
…1177)

ADDON-69825
- The generated files and source files are compared with their names. If
the names are same, warning log for such files is mentioned.
- Reason: the file names would be same when generated from globalConfig
vs present in the source code such that the source code would replace
the generated code.

- Updated the test case when the warning logs should be present and
absent.

---------

Co-authored-by: Artem Rys <rysartem@gmail.com>
Add configurable support for none text files, via encoding content to
base64 string.
https://splunk.atlassian.net/browse/ADDON-69993
**Issue number:** ---

## Summary
Fix path reference inside smoke tests.
Previously 2 tests pointed to static "expected" files that were added
manually
### Changes

> Changes path reference to temp directory instead of static files

### User experience

> Not apllicable

## Checklist

If your change doesn't seem to apply, please leave them unchecked.

* [x] I have performed a self-review of this change
* [x] Changes have been tested
* [ ] Changes are documented
* [x] PR title follows [conventional commit
semantics](https://www.conventionalcommits.org/en/v1.0.0/)
…mework " (#1195)

Reverts #1177

This PR needs a bit more work to be able to be merged into the `develop`
branch, specifically we need to check for the content of the file, not
only the name of the file that is being generated.
Updating the globalConfig before validating with `schema.json` to
provide straightforward upgrade of the add-on.

---------

Co-authored-by: Artem Rys <rysartem@gmail.com>
@sgoral-splunk sgoral-splunk requested review from a team as code owners May 14, 2024 15:01
Copy link
Contributor

@soleksy-splunk soleksy-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sgoral-splunk sgoral-splunk merged commit 3a74e16 into main May 14, 2024
102 of 104 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants