-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge develop into main #1196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinja2 to v3.1.4 [changelog](https://jinja.palletsprojects.com/changes/)) | `3.1.3` -> `3.1.4` Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…1175) - Remove white background from the checkboxgroup storybook - Update the checkboxgroup screenshot and docs. - add a default value for the required field in checkboxgroup. --------- Co-authored-by: srv-rr-github-token <94607705+srv-rr-github-token@users.noreply.github.com> Co-authored-by: Artem Rys <rysartem@gmail.com>
lockFileMaintenance, All locks refreshed update eslint to ^8.26.0 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Szymon Oleksy <soleksy@splunk.com>
Separation done similar to: https://splunk.github.io/addonfactory-ucc-generator/advanced/custom_rest_handler/ Fixes #331. Co-authored-by: mahirchavda <mahir.chavda13@gmail.com> --------- Co-authored-by: Artem Rys <rysartem@gmail.com>
…figuration page (#1181) - Added support for text truncation when the page width is too small. - Adjusted the button width to prevent the label from overflowing beyond the button's border. - Here is the reference: screenshot before the fix: <img width="1028" alt="Screenshot 2024-05-06 at 11 44 03 AM" src="https://github.com/splunk/addonfactory-ucc-generator/assets/163995910/821bfb86-e39d-4d36-af0c-80ef0e84d682"> screenshot after the fix: <img width="1053" alt="Screenshot 2024-05-09 at 3 01 32 PM" src="https://github.com/splunk/addonfactory-ucc-generator/assets/163995910/471fe0b8-90ba-4148-8c9d-9b89268f7410"> --------- Co-authored-by: srv-rr-github-token <94607705+srv-rr-github-token@users.noreply.github.com> Co-authored-by: Artem Rys <rysartem@gmail.com>
- Update `@splunk/react-ui` to v4.30.0
This PR introduces a new PR template.
…1177) ADDON-69825 - The generated files and source files are compared with their names. If the names are same, warning log for such files is mentioned. - Reason: the file names would be same when generated from globalConfig vs present in the source code such that the source code would replace the generated code. - Updated the test case when the warning logs should be present and absent. --------- Co-authored-by: Artem Rys <rysartem@gmail.com>
Add configurable support for none text files, via encoding content to base64 string. https://splunk.atlassian.net/browse/ADDON-69993
**Issue number:** --- ## Summary Fix path reference inside smoke tests. Previously 2 tests pointed to static "expected" files that were added manually ### Changes > Changes path reference to temp directory instead of static files ### User experience > Not apllicable ## Checklist If your change doesn't seem to apply, please leave them unchecked. * [x] I have performed a self-review of this change * [x] Changes have been tested * [ ] Changes are documented * [x] PR title follows [conventional commit semantics](https://www.conventionalcommits.org/en/v1.0.0/)
Updating the globalConfig before validating with `schema.json` to provide straightforward upgrade of the add-on. --------- Co-authored-by: Artem Rys <rysartem@gmail.com>
soleksy-splunk
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.