Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maint: Fix app.builder.outdir as Sphinx now using pathlib #1155

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Maint: Fix app.builder.outdir as Sphinx now using pathlib #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc2343c
fix for sphinx using pathlib
lucyleeow Jul 31, 2023
bfd68e8
empty trigger CI
lucyleeow Jul 31, 2023
d0e19bb
fix pathlib in test
lucyleeow Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion sphinx_gallery/docs_resolv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ def _embed_code_links(app, gallery_conf, gallery_dir):
if url is None:
doc_resolvers[this_module] = SphinxDocLinkResolver(
app.config.sphinx_gallery_conf,
app.builder.outdir, src_gallery_dir, relative=True)
str(app.builder.outdir), src_gallery_dir, relative=True)
else:
doc_resolvers[this_module] = SphinxDocLinkResolver(
app.config.sphinx_gallery_conf,
Expand Down
2 changes: 1 addition & 1 deletion sphinx_gallery/tests/test_full.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def test_junit(sphinx_app, tmpdir):

def test_run_sphinx(sphinx_app):
"""Test basic outputs."""
out_dir = sphinx_app.outdir
out_dir = str(sphinx_app.outdir)
out_files = os.listdir(out_dir)
assert 'index.html' in out_files
assert 'auto_examples' in out_files
Expand Down