Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Upgrade to codecov v4 #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 4, 2024

Short description

GitHub Actions: Upgrade to codecov v4

Proposed changes

Resolved issues

Fixes: #69

@cclauss cclauss marked this pull request as draft March 4, 2024 21:29
Copy link
Collaborator

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss I really appreciate your effort, but if it doesn't work out in a reasonable amount of time, I think it might not be worth it. Maybe it's really a bug in the upstream action which will be resolved in the future. For the moment, v3 should work just fine for us 🥲

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (e9d4308) to head (8339a13).

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #70      +/-   ##
===========================================
- Coverage   100.00%   99.64%   -0.36%     
===========================================
  Files           10       20      +10     
  Lines          328      559     +231     
===========================================
+ Hits           328      557     +229     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cclauss cclauss marked this pull request as ready for review March 4, 2024 21:44
@cclauss
Copy link
Contributor Author

cclauss commented Mar 4, 2024

Snap!

Copy link
Collaborator

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for figuring that out!
Maybe we have to exclude setup.py explicitly from the coverage report to not get a decrease in coverage?
In my opinion, this is justified, since the setup itself is usually never covered by the unit tests, right?

@cclauss
Copy link
Contributor Author

cclauss commented Mar 4, 2024

setup.py usually goes untested and more and more it is just getting removed.

@timobrembeck
Copy link
Collaborator

setup.py usually goes untested and more and more it is just getting removed.

* https://setuptools.pypa.io/en/latest/deprecated/commands.html

Right, I'm also fine with removing it. 👍
It should have no downsides for users installing this package via pip, right?

@cclauss
Copy link
Contributor Author

cclauss commented Mar 4, 2024

Let's not lose setup.py in this pull request. I doubt the loss of one-third of 1% is caused by the presence of setup.py. Once this PR is merged then 99.64% will be the coverage's new normal (green). See section 06 of https://about.codecov.io/resource/what-is-code-coverage on why 100% coverage is not vital.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants