Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃敡 Narrow typing for Builder.build method #12357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

馃敡 Narrow typing for Builder.build method #12357

wants to merge 1 commit into from

Conversation

chrisjsewell
Copy link
Member

No description provided.

picnixz
picnixz reviewed May 7, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest having a type alias somewhere (and runtime accessible since we don't correctly support yet literal types guarded by a TYPE_CHECKING guard).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisjsewell @picnixz