HTML Search: Fix removal of unwanted anchor content from search results #12321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlach
force-pushed
the
fix-headerlink-removal
branch
from
14d95ff
to
04d4b4e
Compare
wlach
commented
Apr 24, 2024
| @@ -178,7 +178,7 @@ const Search = { | |||
|
|
|||
| htmlToText: (htmlString, anchor) => { | |||
| const htmlElement = new DOMParser().parseFromString(htmlString, 'text/html'); | |||
| for (const removalQuery of [".headerlinks", "script", "style"]) { | |||
| for (const removalQuery of [".headerlink", "script", "style"]) { | |||
There was a problem hiding this comment.
This was (correctly) spelled .headerlink before.
|
@jayaddison @picnixz Can you take a look? Looks like an accidental regression from some previous work. |
wlach
force-pushed
the
fix-headerlink-removal
branch
from
04d4b4e
to
8ca1b67
Compare
jayaddison
approved these changes
Apr 24, 2024
jayaddison
added
type:bug
builder:html
html search
javascript
jayaddison
reviewed
Apr 24, 2024
|
Thanks Will! Out of interest, would you be interested in triage permissions, to hopefully make your work on the search features easier? A |
Yep, that'd be great! Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Fix removal of unwanted anchor content from search results
Feature or Bugfix
Purpose
This was accidentally broken in bf0bec3 (#12057), this just fixes it (and updates the existing test so it hopefully doesn't happen again).
Detail
N/A
Relates
Closes #12320