Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more i18n tests #12277

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Add more i18n tests #12277

merged 6 commits into from
Apr 23, 2024

Conversation

n-peugnet
Copy link
Contributor

@n-peugnet n-peugnet commented Apr 14, 2024

While working on #12238, I noticed that some portion of the i18n workflow were not entirely tested. As I rely on these tests to make sure that my refactoring does not affect the output, I figured it could be useful to add more tests.

Feature or Bugfix

  • Tests

Purpose

  • Add test for basic literal block & literalinclude translation
  • Add gettext builder test for litteral blocks additional targets
  • Add i18n test for xref roles in titles
  • Add i18n tests for strange markup

@n-peugnet
Copy link
Contributor Author

I just added some more test cases. While I was working on this, I noticed a corner case (taken from the reStructuredText markup specification) that could not be translated: n-peugnet/sphinx@add-intl-tests...n-peugnet:sphinx:strange-paragraph-i18n

It is working as expected with #12238

@AA-Turner AA-Turner merged commit 55ca37f into sphinx-doc:master Apr 23, 2024
21 of 23 checks passed
n-peugnet added a commit to n-peugnet/sphinx that referenced this pull request Apr 27, 2024
@n-peugnet n-peugnet deleted the add-intl-tests branch April 27, 2024 23:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants