Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean sys.modules if TYPE_CHECKING=True import fails #11645

Merged

Commits on Aug 28, 2023

  1. Clean sys.modules if TYPE_CHECKING=True import fails

    autodoc now attempts to import with `typing.TYPE_CHECKING = True`
    first, and then falls back to `typing.TYPE_CHECKING = False` if that
    fails. Unfortunately, the first import can leave behind some
    partially-imported modules in `sys.modules` such that the retry fails.
    
    Attempt to work around this by detecting what modules were added to
    `sys.modules` by the first attempt and removing them before retrying.
    
    Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
    godlygeek committed Aug 28, 2023
    Copy the full SHA
    8528c31 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Copy the full SHA
    9220b7f View commit details
    Browse the repository at this point in the history
  2. style

    AA-Turner committed Aug 29, 2023
    Copy the full SHA
    186618a View commit details
    Browse the repository at this point in the history
  3. Add CHANGES entry

    godlygeek committed Aug 29, 2023
    Copy the full SHA
    4023ecd View commit details
    Browse the repository at this point in the history
  4. Add credit

    AA-Turner committed Aug 29, 2023
    Copy the full SHA
    ae36324 View commit details
    Browse the repository at this point in the history