linkcheck builder: begin using session-based HTTP requests

[jayaddison]

Feature or Bugfix

• Bugfix
• Refactoring

Purpose

• Reduce the number of HTTP connections used during linkchecking, reducing network resource usage.

Detail

• Resolves linkcheck builder: begin using requests.Session functionality during linkchecking #11324.

Relates

• Re-spin of linkcheck builder: begin using session-based HTTP requests #11340 following some interim refactors and cleanups of the linkcheck builder.

[AA-Turner]

Should we rewrite the existing get and head in terms of a session? This is how requests implements its module-level request methods, might make sense to take inspiration from that.

A

[jayaddison]

It's probably a good idea to re-use the same code paths for both methods.. my rationale when duplicating the implementations was to avoid modifying any non-linkcheck-builder code.

I'll take another look into consolidating them into shared implementations.

[jayaddison]

What do you think of the approach in b7d7fcf ?

[AA-Turner]

I've pushed a commit to only implement the lower-level Session.request, to avoid duplication -- hopefully all looks good!

A

[jayaddison]

I've pushed a commit to only implement the lower-level Session.request, to avoid duplication -- hopefully all looks good!

Nice - yep, that looks much better to me 👍

[AA-Turner]

Thanks @jayaddison -- this is the culmination of quite a bit of preparatory work, thank you for driving this all through!

A

[jayaddison]

Thank you very much @AA-Turner :)

You're welcome. I'll follow along with the next release to listen for user feedback.