Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow anchors to be ignored for specific URLs #11489

Merged
merged 7 commits into from Jul 24, 2023
Merged

Allow anchors to be ignored for specific URLs #11489

merged 7 commits into from Jul 24, 2023

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jul 16, 2023

Closes #11484

francoisfreitag
francoisfreitag approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, thank you!

tests/test_build_linkcheck.py Outdated Show resolved Hide resolved
@picnixz picnixz force-pushed the feature/11484-linkcheck-blacklist branch 2 times, most recently from 79d9af7 to 3ca85aa Compare July 18, 2023 07:00
@picnixz picnixz force-pushed the feature/11484-linkcheck-blacklist branch from 3ca85aa to 3e57128 Compare July 18, 2023 07:01
@AA-Turner
Copy link
Member

@picnixz -- this has conflicts now, please may you resolve?

A

@picnixz picnixz mentioned this pull request Jul 24, 2023
Closed
@jayaddison
Copy link
Contributor

Checking my understanding of this feature, as a non-blocking comment: this feature essentially trims the anchor component of matching URL patterns, resulting in the containing page URL being checked, with presence of the anchor unchecked.

@picnixz
Copy link
Member Author

picnixz commented Jul 24, 2023

Thank you for reorganizing the CHANGELOG (from one PR to another, I always forget whether I should put it at the top or the bottom of the changelist 😅) and correcting my English !

@AA-Turner
Copy link
Member

No worries, it's a subtle feature to describe -- I went with "skip verifying that the anchors exist" as I think it captures what/why a user would gain from enabling the feature.

I'm going to do a review of CHANGES just now before the release (hopefully later today), so will fix order then -- I tend to go for the order in which features were added.

A

@AA-Turner AA-Turner merged commit 82bc15a into sphinx-doc:master Jul 24, 2023
30 checks passed
@picnixz picnixz deleted the feature/11484-linkcheck-blacklist branch July 24, 2023 11:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@francoisfreitag francoisfreitag francoisfreitag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow disabling linkcheck anchor checks for specific URLs
4 participants
@picnixz @AA-Turner @jayaddison @francoisfreitag