Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility issue: pin to 'urllib3<2.0.0' pending support in 'requests' #11420

Closed
wants to merge 1 commit into from
Closed

Compatibility issue: pin to 'urllib3<2.0.0' pending support in 'requests' #11420

wants to merge 1 commit into from

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Purpose

  • Ensure dependency compatibility between requests and urllib3 versions in pyproject.toml.
  • Limitation: may not ensure compatibility when sphinx itself is installed as a Python package dependency.

Relates

@jayaddison
Copy link
Contributor Author

Closing, since requests v2.30.0 does in fact appear to support urllib3 v2.0.0 and beyond (requests v2.29.0 did not, and a fix in urllib3 2.0.2 did expose a thread-safety issue in the sphinx unit tests).

@jayaddison jayaddison closed this May 14, 2023
@jayaddison jayaddison deleted the issue-11419/requests-pre3-urllib-post1-incompatibility branch May 14, 2023 19:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dependency incompatibility: requests (latest:2.30.0), urllib3>=2.0.0
1 participant
@jayaddison