Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support type comments in PropertyDocumenter #11298

Merged
merged 3 commits into from Apr 6, 2023
Merged

Support type comments in PropertyDocumenter #11298

merged 3 commits into from Apr 6, 2023

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Apr 6, 2023

Fix #11277

@picnixz picnixz marked this pull request as draft April 6, 2023 14:04
@picnixz picnixz marked this pull request as ready for review April 6, 2023 14:35
@AA-Turner AA-Turner changed the title Add type comments support in PropertyDocumenter Support type comments in PropertyDocumenter Apr 6, 2023
@AA-Turner AA-Turner merged commit aba392d into sphinx-doc:master Apr 6, 2023
22 checks passed
@AA-Turner
Copy link
Member

Thank you for the very comprehensive report and fix!

A

@picnixz picnixz deleted the fix-11277 branch April 7, 2023 13:49
@AA-Turner AA-Turner added this to the 6.2.0 milestone Apr 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

[BUG] PropertyDocumenter does not add annotation from type comment
2 participants
@picnixz @AA-Turner