LaTeX: add \sphinxnotetitle et al. to sphinxlatexadmonitions.sty
#11266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In passing I reverted some deprecation I had added at 6bf4059 to some internals of the sphinxadmonition environment, as it does not look that pressing anyhow and the redundant namings of two colors in particular may nevertheless prove useful to user \renewcommand's, as they avoid to have to refer to \spx@noticetype.
|
I have pushed to master 321f886 which avoids failed test due to pip currently still using "onerror" which has been deprecated by Python 3.12-dev in favor of "onexc" in shutil.rmtree(). I rebased this on top of that and will merge once testing completes. |
jfbu
added a commit
to jfbu/sphinx
that referenced
this pull request
Mar 27, 2023
Follow-up to sphinx-doc#11266. Using \sphinxstyle prefix looked a posteriori better, for coherency, although it is a bit long.
|
The added LaTeX commands were renamed at follow-up #11267 for coherence with previous existing ones. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring in sphinxlatexadmonitions.sty also fixes #11264.