Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use black pre-commit #11251

Closed
wants to merge 1 commit into from
Closed

use black pre-commit #11251

wants to merge 1 commit into from

Conversation

12rambau
Copy link

Subject: lint the lib with pre-commits

Feature or Bugfix

Refactoring

Purpose

  • As mentione in the associated issue if one want's to participate in the development of Sphinx, the linter is only executed on Github side. using pre-commits, we could get a more consistent linting test (as everyone would run the same version on the same generated envorionment) and make sure anything that make its way to Github is nicely shaped.

Detail

Relates

Fix #11205

@AA-Turner
Copy link
Member

This was proposed earlier and rejected: #9955

I'm closing for now, thank you for the PR though, and please do look at other open issues!

A

@AA-Turner AA-Turner closed this Mar 23, 2023
@12rambau
Copy link
Author

12rambau commented Mar 24, 2023

thanks for letting me know. note that i did an extra PR (#11204) and the lack of automation for formatting lead me to this PR and the related issue which was well welcolmed by others: #11205.

If black itself is an issue what about checking your existing linter (flake8 + ruff + isort) with pre-commits ?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automation of linting test using pre-commit
2 participants