Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support and prefer .jinja to _t for static templates #11165

Merged
merged 40 commits into from Apr 7, 2023
Merged

Support and prefer .jinja to _t for static templates #11165

merged 40 commits into from Apr 7, 2023

Commits on Feb 3, 2023

  1. Templating: use '.jinja2' suffix on Jinja2 template files instead of … 

    …generic/ambiguous '_t' suffix
    @jayaddison
    jayaddison committed Feb 3, 2023
    Copy the full SHA
    3e735ee View commit details
    Browse the repository at this point in the history

  2. ruff suggestion: adopt union typing syntax (with support provided by … 

    …PEP0563 for pre-py310)
    @jayaddison
    jayaddison committed Feb 3, 2023
    Copy the full SHA
    5ce9483 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Merge branch 'master' into templating/jinja2-suffix

    @jayaddison
    jayaddison committed Feb 13, 2023
    Copy the full SHA
    168cb23 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. Update file extension: the 'jinja2' project has been renamed to 'jinj… 

    …a', so let's simplify the filename extension accordingly
    @jayaddison
    jayaddison committed Feb 19, 2023
    Copy the full SHA
    4a8a339 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into templating/jinja2-suffix

    @jayaddison
    jayaddison committed Feb 19, 2023
    Copy the full SHA
    eb9938a View commit details
    Browse the repository at this point in the history

  3. Fixup: ruff lint error (missing trailing comma after multi-line multi… 

    …-argument method call parameter list)
    @jayaddison
    jayaddison committed Feb 19, 2023
    Copy the full SHA
    43f8b2b View commit details
    Browse the repository at this point in the history

  4. Fixup: adjust trim-length for template suffix (was: seven characters … 

    …for '.jinja2', is now: six characters for '.jinja')

Note: cannot yet simplify this code by using str.removesuffix, since that was introduced in py39 and we are maintaining py38 support
    @jayaddison
    jayaddison committed Feb 19, 2023
    Copy the full SHA
    b2889de View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Localization: undo changes to resource files

    @jayaddison
    jayaddison committed Mar 21, 2023
    Copy the full SHA
    a720933 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into templating/jinja2-suffix

    @jayaddison
    jayaddison committed Mar 21, 2023
    Copy the full SHA
    6f99cef View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Logic adjustment and refactor: rename '_template_basename' utility me… 

    …thod to '_asset_destination', and always return a string result from it
    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    d2af9b5 View commit details
    Browse the repository at this point in the history

  2. Emit a more-generic PendingDeprecationWarning instead of RemovedInSph… 

    …inx80Warning when legacy template suffixes are in use
    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    526fdc7 View commit details
    Browse the repository at this point in the history

  3. CHANGES: document the deprecation of the '_t' file-copy template suffix

    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    cd0d61f View commit details
    Browse the repository at this point in the history

  4. Code commentary / feature removal timeline: provide two years from to… 

    …day before removing support for the '_t' suffix on Sphinx copy-file templates
    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    5ab2226 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into templating/jinja2-suffix

    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    b8570ab View commit details
    Browse the repository at this point in the history

  6. CHANGES: Add issue thread number reference

    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    59534ea View commit details
    Browse the repository at this point in the history

  7. Cleanup: remove unused import 

    Relates to commit 526fdc7.
    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    e38e78e View commit details
    Browse the repository at this point in the history

  8. Documentation: update hint related to LaTeX template filenames

    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    6305f96 View commit details
    Browse the repository at this point in the history

  9. Babel resource extraction: update latex template method mappings to i… 

    …nclude recommended .jinja file suffix
    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    dc850b7 View commit details
    Browse the repository at this point in the history

  10. Babel resource extraction: update javascript template method mapping … 

    …to include .jinja file suffix
    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    04aa946 View commit details
    Browse the repository at this point in the history

  11. Babel resource extraction: update latex template options to include r… 

    …ecommended .jinja file suffix
    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    8572661 View commit details
    Browse the repository at this point in the history

  12. Revert changes to latex file rendering

    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    0eb993d View commit details
    Browse the repository at this point in the history

  13. LaTeX templating: re-migrate to preferred '.tex.jinja' template suffi… 

    …x, while providing backwards-compatibility for locally-deployed project '.tex_t' template file suffixes
    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    0444616 View commit details
    Browse the repository at this point in the history

  14. Fixup: migrate imgmath LaTeX template to use .jinja suffix

    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    29fb6f0 View commit details
    Browse the repository at this point in the history

  15. Test coverage: ensure that we have test coverage for the legacy LaTeX… 

    … template suffix
    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    1630cc8 View commit details
    Browse the repository at this point in the history

  16. Fixup: migrate built-in preview.tex LaTeX template

    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    d85f016 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'master' into templating/jinja2-suffix

    @AA-Turner
    AA-Turner committed Apr 6, 2023
    Copy the full SHA
    8475023 View commit details
    Browse the repository at this point in the history

  18. CHANGES: Update deprecation note to mention built-in templates

    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    bc43d2e View commit details
    Browse the repository at this point in the history

  19. imgmath LaTeX templating: provide backwards-compatibility in the case… 

    … of locally-deployed project '.tex_t'-suffixed template files
    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    06aa004 View commit details
    Browse the repository at this point in the history

  20. Safety in code path where a multi-item iterable is expected to be red… 

    …uced to a single element in future: use list literal instead of tuple literal representation
    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    7b061cf View commit details
    Browse the repository at this point in the history

  21. Fixup: add missing import

    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    abd8af5 View commit details
    Browse the repository at this point in the history

  22. Revert "Logic adjustment and refactor: rename '_template_basename' ut… 

    …ility method to '_asset_destination', and always return a string result from it"

This reverts commit d2af9b5.
    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    d8e3fa7 View commit details
    Browse the repository at this point in the history

  23. Fixup: imgmath: fallback to template filename with .jinja suffix

    @jayaddison
    jayaddison committed Apr 6, 2023
    Copy the full SHA
    30c7318 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Template suffix iteration: use the 'tuple' datatype instead of 'list'… 

    … to hold the suffix string elements

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
    @jayaddison @AA-Turner
    jayaddison and AA-Turner committed Apr 7, 2023
    Copy the full SHA
    d0aa68a View commit details
    Browse the repository at this point in the history

  2. Documentation: add explanatory docstring to utility '_template_basena… 

    …me' method
    @jayaddison
    jayaddison committed Apr 7, 2023
    Copy the full SHA
    299dbed View commit details
    Browse the repository at this point in the history

  3. Adjust date, add helper function

    @AA-Turner
    AA-Turner committed Apr 7, 2023
    Copy the full SHA
    c3b5cb9 View commit details
    Browse the repository at this point in the history

  4. Add tests

    @AA-Turner
    AA-Turner committed Apr 7, 2023
    Copy the full SHA
    6600615 View commit details
    Browse the repository at this point in the history

  5. Update theming.rst

    @AA-Turner
    AA-Turner committed Apr 7, 2023
    Copy the full SHA
    9327357 View commit details
    Browse the repository at this point in the history

  6. Update CHANGES

    @AA-Turner
    AA-Turner committed Apr 7, 2023
    Copy the full SHA
    cccdfaf View commit details
    Browse the repository at this point in the history

  7. left -> removed

    @AA-Turner
    AA-Turner committed Apr 7, 2023
    Copy the full SHA
    cb9ea44 View commit details
    Browse the repository at this point in the history

  8. credits

    @AA-Turner
    AA-Turner committed Apr 7, 2023
    Copy the full SHA
    9a4410a View commit details
    Browse the repository at this point in the history