Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable localisation when
SOURCE_DATE_EPOCH
is set #10949Disable localisation when
SOURCE_DATE_EPOCH
is set #10949Changes from 29 commits
61ac761
2592766
c1d2473
babbb27
f17cf4a
ed704c3
fae1b1a
1cb30df
b300d8b
3667842
336ea1c
9b0acb3
873a350
121fc1d
6585538
04f7058
b264cb2
8377534
aa7e165
bb02c92
4587f76
2fc96ec
15edb4c
1fb6ccc
6a880ad
52a7104
a73459b
dd41420
426e08e
a9c9100
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may seem overly complicated compared to, for example:
...which would achieve similar results.
My thinking here is that the presence/absence of
SOURCE_DATE_EPOCH
should, ideally, minimize the effect on the control flow of the program and build.If the environment variable results in completely different control flows, then arguably the program being built is different.
My sense is that the ideal roadmap for
SOURCE_DATE_EPOCH
is to introduce it as-required to achieve reproducible builds, but also to keep in mind that it should be removed in future when no-longer-required.(and to be precise in the case of
sphinx
: a potential time for removal would be when it's possible to perform deterministic documentation builds in all-available-locales -- meaning that the software would be packaged for universal applicability and should build into an identical artefact regardless of the build host's locale)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is realistic to achive this, I think it's a good goal -- would you be happy to open a new issue to track the 'locale independent' workstream?
A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From searching around before doing that, I think that this would be approximately the same as #788 (although that is specific to HTML, currently).
I'll spend some more time reading before deciding whether to add more comments there or to open a separate ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I appreciate your help here!
A